-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiP: Imported tokens form #5256
Draft
mstrasinskis
wants to merge
172
commits into
main
Choose a base branch
from
mstr/imported-tokens-form
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,332
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inity/nns-dapp into mstr/imported-tokens-services
# Conflicts: # frontend/src/lib/i18n/en.json
commit 3fa7e3f Author: Max Strasinsky <[email protected]> Date: Thu Aug 15 14:01:08 2024 +0200 Changelog commit 592830e Author: Max Strasinsky <[email protected]> Date: Thu Aug 15 13:36:49 2024 +0200 Attempt to fix safari table glitch
This reverts commit fb9907d.
# Conflicts: # frontend/src/lib/components/accounts/WalletPageHeader.svelte # frontend/src/lib/i18n/en.json # frontend/src/lib/pages/NnsWallet.svelte # frontend/src/lib/types/i18n.d.ts # frontend/src/tests/lib/pages/NnsWallet.spec.ts # frontend/src/tests/page-objects/NnsWallet.page-object.ts
commit 2acd2fd Author: Max Strasinsky <[email protected]> Date: Tue Aug 27 11:57:53 2024 +0200 Use ConfirmationModal for ImportTokenRemoveConfirmation commit 19f982a Author: Max Strasinsky <[email protected]> Date: Tue Aug 27 11:57:27 2024 +0200 Add optional labels support to ConfirmationModal.svelte commit d38fa0a Author: Max Strasinsky <[email protected]> Date: Mon Aug 26 17:03:44 2024 +0200 Update imports commit 3d8fc9e Author: Max Strasinsky <[email protected]> Date: Mon Aug 26 16:51:29 2024 +0200 Remove testing of the static description commit 0f244fa Author: Max Strasinsky <[email protected]> Date: Mon Aug 26 16:51:08 2024 +0200 Split remove_confirmation_description into 2 messages commit 25fa501 Author: Max Strasinsky <[email protected]> Date: Mon Aug 26 16:35:38 2024 +0200 Provide universe instead of ledgerCanisterId to the ImportTokenRemoveConfirmation component commit 3a935ba Author: Max Strasinsky <[email protected]> Date: Mon Aug 26 16:34:24 2024 +0200 Use cancel label for cancel button commit 85e2686 Author: Max Strasinsky <[email protected]> Date: Fri Aug 23 15:31:24 2024 +0200 Formatting commit 38d5c58 Author: Max Strasinsky <[email protected]> Date: Fri Aug 23 14:46:31 2024 +0200 Add missing label commit 00b82c3 Author: Max Strasinsky <[email protected]> Date: Fri Aug 23 14:37:37 2024 +0200 test: ImportTokenRemoveConfirmation commit 454b4c4 Author: Max Strasinsky <[email protected]> Date: Fri Aug 23 14:37:32 2024 +0200 New ImportTokenRemoveConfirmation component commit 699e9b6 Author: David de Kloet <[email protected]> Date: Fri Aug 23 08:59:21 2024 +0200 Update SNS aggregator changelog for proposal 129614 (#5346) # Motivation We forgot to update the SNS aggregator changelog after the [upgrade](https://dashboard.internetcomputer.org/proposal/129614) back in May. # Changes Move the entries that were already there before the previous upgrade, to a separate section. I also updated the release SOP for the aggregator to include an item about the changelog. # Tests n/a # Todos - [x] Add entry to changelog (if necessary). commit 00d108b Author: sa-github-api <[email protected]> Date: Fri Aug 23 01:47:17 2024 -0500 bot: Update snsdemo to release-2024-08-21 (#5345) # Motivation We would like to keep the testing environment, provided by snsdemo, up to date. # Changes * Updated `snsdemo` version in `dfx.json`. * Ensured that the `dfx` version in `dfx.json` matches `snsdemo`. # Tests CI should pass. Co-authored-by: gix-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Tests
Todos